Re: XForms: autoconf/automake patch

From: Jean-Marc Lasgouttes (Jean-Marc.Lasgouttes@inria.fr)
Date: Wed Apr 23 2003 - 08:49:53 EDT

  • Next message: Jean-Marc Lasgouttes: "Re: XForms: autoconf/automake patch"

    # To subscribers of the xforms list from Jean-Marc Lasgouttes <Jean-Marc.Lasgouttes@inria.fr> :

    >>>>> "Angus" == Angus Leeming <angus.leeming@btopenworld.com> writes:

    Angus> # To subscribers of the xforms list from Angus Leeming
    Angus> <angus.leeming@btopenworld.com> : I think that the switch to
    Angus> autoconf/automake is ready to go. Find the patch at
    Angus> http://www.devel.lyx.org/~leeming/auto.diff.bz2 It's 94kB in
    Angus> size.

    Angus> I've tested that all is OK on an RH8 linux box and on a DEC
    Angus> Alpha running Tru64 Unix 4.0e with the native compiler chain
    Angus> (including DEC's make).

    It seems to work up to now. A few comments (I do not provide a patch,
    unless you commit your patch first).

    ** In autogen.sh:

    - the check for GNUM4 is not needed.

    ** In configure.ac:

    - the version 1.1cvs is not the same as the version in forms.h

    - I am not sure that you need the following lines:
    PACKAGE=xforms
    VERSION="1.1cvs"
    but then XFORMS_CHECK_VERSION should look at PACKAGE_VERSION variable.

    - why not generate config.h in lib/ ?

    - the check for M4 is not needed

    - did you check that the HAVE_foo defines generated in config.h are
      actually used somewhere? If not, it means that the library used to
      compile without them and you should remove the tests altogether

    - I think you can remove the following:

    dnl This is a slight hack: the tests generated by autoconf 2.52 do not
    dnl work correctly because of some conflict with stdlib.h with g++ 2.96
    dnl We aim to remove this eventually, since we should test as much as
    dnl possible with the compiler which will use the functions (JMarc)
    XFORMS_CHECK_DECL(mkstemp,[unistd.h stdlib.h])

    - I think you can safely remove the whole AH_BOTTOM thing

    ** When building I get a _lot_ of warnings about unused parameters,
       but I guess you know that already.

    ** running: some of the demos do not run when building outside of
       source tree

    More to come later, I guess.

    JMarc
    _________________________________________________
    To unsubscribe, send the message "unsubscribe" to
    xforms-request@bob.usuhs.mil or see
    http://bob.usuhs.mil/mailserv/xforms.html
    XForms Home Page: http://world.std.com/~xforms
    List Archive: http://bob.usuhs.mil/mailserv/list-archives/
    Development: http://savannah.nongnu.org/files/?group=xforms



    This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 08:51:22 EDT